Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Invalid numeric indices prevent menu presentation instead of using the documented no-highlight fallback.
1 open finding
What changed in this PR
Adds context-menu presentation options across the JavaScript API, Swift bridge, and macOS editor.
Changes:
- Passes
highlightedIndexthrough to native menu presentation. - Checks item eligibility and JavaScript state before highlighting.
- Updates the API dependency and adds regression tests.
| File | Description |
|---|---|
| MarkEditMac/Tests/ContextMenuTests.swift | Tests native highlighting and item state. |
| MarkEditMac/Sources/Editor/Controllers/EditorViewController+UI.swift | Implements initial menu highlighting. |
| MarkEditMac/Sources/Editor/Controllers/EditorViewController+Delegate.swift | Forwards the requested index. |
| MarkEditMac/Modules/Tests/FileVersionTests.swift | Updates the delegate stub. |
| MarkEditKit/Tests/MoveFileTests.swift | Updates the delegate stub. |
| MarkEditKit/Sources/Bridge/Native/Modules/EditorModuleAPI.swift | Extends native API forwarding. |
| MarkEditKit/Sources/Bridge/Native/Generated/NativeModuleAPI.swift | Decodes the optional index. |
| MarkEdit.xcodeproj/project.pbxproj | Registers context-menu tests and reorders entries. |
| CoreEditor/yarn.lock | Locks the updated API dependency. |
| CoreEditor/test/nestedEditors.test.ts | Tests options, geometry, and index validation. |
| CoreEditor/src/bridge/native/api.ts | Extends the bridge interface. |
| CoreEditor/src/api/ui.ts | Accepts, validates, and forwards options. |
| CoreEditor/package.json | Updates markedit-api to v0.38.0. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.