Repository navigation
Add markedit-file-explorer v0.1.3 - #55
Conversation
|
Thank you for your contribution. This is quite an interesting extension. I tested it, and it seems to be mostly functional. However, I noticed that sometimes after opening a file as a new tab, the file selection switches back to the previously selected file. This is not a blocker but worth looking into. |
|
Two more AI-assisted findings:
Both were reproduced against the tagged TypeScript using mocked MarkEdit file APIs, not through the live macOS UI. |
|
Thank you for the feedback @cyanzhong! Looking into these items now. |
|
Hi @cyanzhong, thanks again for testing so thoroughly! Regarding the issue you found manually - selection switching back after opening a tab - I've been clicking around like mad trying to repro, but haven't been able to catch it happening. A few questions, if you have a sec:
My best guess so far, explaining some of the questions: with a double-click, the new tab can appear before the second click comes in, so that click reaches the new tab's explorer and can open whichever row happens to be under the cursor when the second click registers. But I don't want to go modifying click timings or anything until I can figure out if that's what's happening. Another possibility: Might it be interacting poorly with another installed extension? Now regarding your two P2 findings: both confirmed, good catches! I'll fix them in 0.1.2, add regression tests for both scenarios, and update this PR to point at the new release. |
b1749e1 to
96dda82
Compare
|
Both P2s findings are now fixed in v0.1.2, and I've updated this PR to point at the new release:
Failed moves and copies are also reported now instead of skipped silently. Both of your scenarios are covered by regression tests against mocked file APIs ( |
|
Discovered a couple minor UX bugs while testing - fixing and pushing a new version shortly |
96dda82 to
5d712b0
Compare
|
pushed, all good 👍 |
|
Thank you for the updates! |
|
@dorkusprime I am working on some new APIs and it may be useful for this extension: openDocument(path: string, options?: { target?: 'automatic' | 'window' | 'tab' }): Promise<boolean>Instead of relying on MarkEdit as the default app for markdown files, this API ensures opening plain text files in MarkEdit, and can specify the window grouping strategy. Also: showOpenPanel(options?: OpenPanelOptions): Promise<string[] | undefined>This prompts the user to open a file or directory and returns the file paths. |
|
@cyanzhong Oh awesome, I was actually thinking about submitting a feature request along those lines to drop some of the workarounds and expectations in the extension.
I'll switch over as soon as these land, and I'm happy to test a pre-release build if that helps. Thanks again for merging! |
|
Feel free to test the API using this preview build: I am still working on a few things before I can finalize the next release. |
First, thank you for MarkEdit. I love it: it's fast, native and a genuine pleasure to write in, and MarkEdit-api makes it just as nice to build on.
Why: moving between files currently means switching to Finder, ForkLift or another file manager, finding the right folder, opening the file and switching back, a small detour that breaks the focus MarkEdit is so good at keeping. File Explorer adds a VS Code-style folder tree beside the editor so that step stays in MarkEdit. In keeping with Why MarkEdit, it isn't a notes app: no index or database, just the folders you already have, as plain files.
What it does: lazy folder tree with compact folders and indent guides; click to open Markdown (other types MarkEdit can open are configurable, the rest are dimmed or hidden); inline new file / folder / rename; cut / copy / paste, drag & drop, delete to Trash; keyboard navigation; theme-matched styling. It coexists with the Outline Sidebar extension and keeps its state in sync across tabs.
dist/matchesValidated with
node scripts/build.mjs(including the integrity check against the release asset) andnpm test.