TICKET-637: Set course dates from term on LTI course creation#8057
TICKET-637: Set course dates from term on LTI course creation#8057Naragod wants to merge 2 commits into
Conversation
Coverage Report for CI Build 30036542150Warning No base build found for commit Coverage: 90.533%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats💛 - Coveralls |
|
Looks good! Please update branch and I will approve. Thank you. |
8d2ca66 to
551eecf
Compare
|
@Naragod and @david-yz-liu, I noticed that when a course is created via LTI with the term "2026 Fall-Winter", MarkUs sets the course dates to Sept 1 – Dec 31. The same happens for full-year (Y) courses, e.g. LSM999Y1-Y-LEC0101-20269 in the SIS ID. Shouldn't these span Sept 1 – Apr 30? Or does a MarkUs course only cover a single term? |
|
@donny-wong you're right, for year-long courses it should go Sept 1 - April 30 |
Proposed Changes - ✨ New feature
Courses created through the Canvas LTI flow now start with term dates filled in. Before this change, instructors set both dates by hand after every course creation.
LtiConfig.get_course_datesturns the term into a four-month window. "Fall 2025" becomes Sep 1 to Dec 31, 2025.LSM999Y1-Y-LEC0101-20259) wins over the term name when both are present.term_namecustom claim.get_course_dateskeep working through arespond_to?guard.Screenshots of your changes (if applicable)
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)