Skip to content

fix: a lease commit spammed the pull request's timeline - #20

Merged
MarketDataApp merged 2 commits into
mainfrom
fix/lease-commit-cross-references
Sep 22, 2026
Merged

MarketDataApp merged 2 commits into
mainfrom
fix/lease-commit-cross-references

fix: LeaseSpan.holder depended on the message format and on being closed

fb444cd
Select commit
Loading
Failed to load commit list.
marketdata-code-review / Code review succeeded Sep 22, 2026 in 0s

✅ Ready

This change removes GitHub cross-repository references from lease commit messages while preserving the stored holder identity. The history parser supports both old and new message formats and normalizes them to the same lease span identity.

Annotations

Check notice on line 129 in reviewbot/credentials.py

See this annotation in the file changed.

@marketdata-code-review marketdata-code-review / Code review

Move dated incident narrative out of code

The new docstring embeds a dated incident report and measurements that belong in the pull request or commit history. The cited house-style examples do not override the standing rule for newly added comments; retain only the enduring constraint that raw holders create cross-references.