[MarketDataDev02]

Why

After #25 each SDK had to list codecov/patch and codecov/project in its own policy, as sdk-py #163 did. Codecov reports on sdk-py, sdk-csharp, sdk-php, sdk-go and sdk-java, so that line repeated one decision five times. It belongs in the bot.

The change

• reviewbot/defaults/policy.yml: wait_for_checks: ["codecov/patch", "codecov/project"] and wait_for_checks_seconds: 120, where they were [] and 300.
• reviewbot wait-for-checks does not wait when every changed file matches ignore_paths, since the review skips that pull request anyway. It reads the changed files once to tell.
• docs/setup.md: the default; wait_for_checks: [] to turn it off; and that a failing check, listed or not, skips the review, so informational: true in a repository's Codecov configuration keeps coverage from holding a review back.

Why the bot does not detect Codecov per repository

Checked on the six SDKs:

• On the default branch Codecov posts commit statuses (sdk-py) or nothing, because CI does not run there (sdk-csharp). The App has no statuses permission, so it cannot read them.
• GitHub creates a codecov check suite on every head, sdk-js included, and it stays queued where Codecov never reports.
• Codecov check runs on recent merged pull request heads: sdk-py 4 of 6, sdk-csharp 3 of 6, sdk-php 3 of 4, sdk-go 5 of 6, sdk-java 2 of 5, sdk-js 0 of 6. Most without are dependabot's, which the gate refuses before the wait, and documentation-only changes.

So where Codecov does not report, a review waits the cap, which is why the default is two minutes rather than five. Codecov reported 35 to 50 seconds after Tests on sdk-py, well inside it.

Rollout

• sdk-js adds wait_for_checks: [] to its policy. The key exists since feat: wait for the checks another app reports after CI, before reading it #25, so this can land before or after this pull request.
• sdk-py's explicit list from #163 now equals the default; it can stay.
• _lease_minutes already reserves the wait in the job budget, now two minutes for every repository that waits. That shortens a lease wait only from timeout_minutes 18 up.
• On every recent pull request in the five repositories, codecov/patch and codecov/project passed, so the default skips no review today.

Tests

• tests/test_wait_for_checks.py: Codecov is waited for by default; the default gives up after two minutes; a pull request whose files all match ignore_paths neither waits nor pins its head; one file outside them keeps the wait; the real client reads the changed files; an explicit wait_for_checks: [] reads no check run.
• tests/test_config.py: the new defaults, and an empty list turning the wait off.

uv run pytest: 760 passed on Windows. The other 54 fail on an unmodified main on Windows too, because their fake claude and codex executables are POSIX scripts; ubuntu CI runs them. ruff check . and ruff format --check . are clean.

[marketdata-code-review]

✅ Ready — Code review

This changes the default policy to wait up to 120 seconds for the two Codecov checks and skips that wait when all changed paths are ignored. It updates the setup documentation and extends coverage for defaults, opt-out, timeout, path filtering, and real-client requests.

Rating patch 5/6 (solid) · proof 5/6 (reproducible) · overall 5/6

---

Reviewed 289e8f7 · revision 1 · codex (gpt-5.6-sol) · claude unavailable · rules: default