Repository navigation
fix: read a date-only timestamp as midnight US/Eastern - #112
MarketDataDev02 wants to merge 1 commit into
Conversation
|
C:/Program Files/Git/run-all-os |
|
/run-all-os |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #112 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 69 69
Lines 2187 2190 +3
Branches 272 274 +2
=========================================
+ Hits 2187 2190 +3
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
❌ On-demand OS matrix |
Under dateformat=timestamp the API writes a date as %Y-%m-%d, meaning that calendar day in US/Eastern. ToDateTime parsed every string with DateTimeStyles.AssumeUniversal, so a date became UTC midnight and, once converted to America/New_York, 20:00 or 19:00 of the day before: daily stock and fund candles, earnings dates, news dates, option expirations and market status dates. A string of exactly the yyyy-MM-dd shape is now midnight US/Eastern of that day, with the EST or EDT offset in force then. Every other string keeps the offset-aware parse, so datetimes with an offset and the unix format read as before. A length test keeps datetime values off the exact date parse, which would otherwise cost about 200 ns per value when it fails. The explicit non-string branch surfaces a path the old combined condition hid from coverlet, which shares one hit counter per jump target; that path now has its own test.
8fac40c to
428d1d4
Compare
⛔ Blocked — Code reviewThis changes internal timestamp decoding so exact date-only strings become midnight US/Eastern while offset-bearing datetimes and Unix timestamps retain their behavior, with direct and endpoint-level regression tests. Version impact: patch (1.0.0 -> 1.0.1); no public or protected symbol changes. The same defect exists in Python and may exist in PHP; Java, Go, and JavaScript do not share this typed-decoding path. Rating patch 5/6 (solid) · proof 4/6 (adequate) · overall 4/6 Reviewed |
Superseded by #114.