Skip to content

ci(review): review the SDK-sync App's pull requests - #29

Merged
MarketDataDev03 merged 2 commits into
mainfrom
code-review/trust-sdk-sync-app
Nov 2, 2026
Merged

MarketDataDev03 merged 2 commits into
mainfrom
code-review/trust-sdk-sync-app

Conversation

@MarketDataDev03

@MarketDataDev03 MarketDataDev03 commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Lets the code review bot review pull requests opened by the SDK-sync pipeline's GitHub App (marketdata-sdk-sync[bot]), as sdk-py and sdk-java already do. An App is not a member of the organization, so the policy trusts it by name. Without this, the pipeline's pull requests here get no code review and are handed to a person.

What changes

One line in .github/code-review/policy.yml, with a comment: trusted_authors: ["marketdata-sdk-sync[bot]"]. Nothing else: backends, gate, require_ci_green, ignore_paths and the review rules stay as they are.

Proof

The same line works in the other SDKs. sdk-java and sdk-py carry this exact line, and the bot reviews the pull requests the App opens there. Each of these is authored by app/marketdata-sdk-sync, and each has a Code review check run that started and completed:

The file parses, with the value in place:

$ python3 -c "import yaml; d = yaml.safe_load(open('.github/code-review/policy.yml')); print(d['trusted_authors'])"
['marketdata-sdk-sync[bot]']

A pull request here from the App is not possible until this merges, because the App's pull requests are not reviewed before then. The first pipeline pull request in this repository is the check here.

@codecov

codecov Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (0275521) to head (e9f3791).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #29   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           44        44           
  Lines         3140      3140           
=========================================
  Hits          3140      3140           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MarketDataDev02 MarketDataDev02 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The policy parses with the bot's own loader into a single trusted_authors entry, marketdata-sdk-sync[bot], which is the exact login on the App's PRs; the trust check only adds listed logins on top of org membership, and the same line already lets the bot review the App's PRs in sdk-py and sdk-java. Lint is the Go 1.27.3 issue that #30 fixes and tuitest failed on a proxy.golang.org download, so update the branch with main after #30 merges (a re-run reuses the old merge commit) and merge once Lint is green.

@marketdata-code-review

marketdata-code-review Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

✅ Ready — Code review

This adds the SDK-sync GitHub App login to the code-review policy's trusted authors so its pull requests receive reviews. Version impact: none; this changes CI policy only and does not touch the exported Go surface.

Rating patch 5/6 (solid) · proof 5/6 (reproducible) · overall 5/6

Since last review

  • Resolved: 891ab73b, d0955cb8
  • 0 still open, 0 new

Reviewed e9f3791 · revision 1 · codex (gpt-5.6-sol) · claude unavailable · rules: default, sdk

@MarketDataDev03

Copy link
Copy Markdown
Collaborator Author

@marketdata-code-review re-review

@MarketDataDev03

Copy link
Copy Markdown
Collaborator Author

@marketdata-code-review re-review

@MarketDataDev03
MarketDataDev03 merged commit 1b3dceb into main Nov 2, 2026
16 checks passed
@MarketDataDev03
MarketDataDev03 deleted the code-review/trust-sdk-sync-app branch November 2, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants