Repository navigation
ci(review): review the SDK-sync App's pull requests - #29
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 44 44
Lines 3140 3140
=========================================
Hits 3140 3140 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
MarketDataDev02
left a comment
There was a problem hiding this comment.
The policy parses with the bot's own loader into a single trusted_authors entry, marketdata-sdk-sync[bot], which is the exact login on the App's PRs; the trust check only adds listed logins on top of org membership, and the same line already lets the bot review the App's PRs in sdk-py and sdk-java. Lint is the Go 1.27.3 issue that #30 fixes and tuitest failed on a proxy.golang.org download, so update the branch with main after #30 merges (a re-run reuses the old merge commit) and merge once Lint is green.
✅ Ready — Code reviewThis adds the SDK-sync GitHub App login to the code-review policy's trusted authors so its pull requests receive reviews. Version impact: none; this changes CI policy only and does not touch the exported Go surface. Rating patch 5/6 (solid) · proof 5/6 (reproducible) · overall 5/6 Since last review
Reviewed |
|
@marketdata-code-review re-review |
|
@marketdata-code-review re-review |
Lets the code review bot review pull requests opened by the SDK-sync pipeline's GitHub App (
marketdata-sdk-sync[bot]), as sdk-py and sdk-java already do. An App is not a member of the organization, so the policy trusts it by name. Without this, the pipeline's pull requests here get no code review and are handed to a person.What changes
One line in
.github/code-review/policy.yml, with a comment:trusted_authors: ["marketdata-sdk-sync[bot]"]. Nothing else: backends,gate,require_ci_green,ignore_pathsand the review rules stay as they are.Proof
The same line works in the other SDKs. sdk-java and sdk-py carry this exact line, and the bot reviews the pull requests the App opens there. Each of these is authored by
app/marketdata-sdk-sync, and each has aCode reviewcheck run that started and completed:The file parses, with the value in place:
A pull request here from the App is not possible until this merges, because the App's pull requests are not reviewed before then. The first pipeline pull request in this repository is the check here.