Skip to content

docs: retarget a stacked PR to main as soon as it is approved - #70

Merged
MarketDataApp merged 1 commit into
mainfrom
docs/stacked-pr-retarget
Sep 14, 2026
Merged

MarketDataApp merged 1 commit into
mainfrom
docs/stacked-pr-retarget

Conversation

@MarketDataApp

Copy link
Copy Markdown
Owner

.github/ISSUE_WORKFLOW.md told a maintainer to open a pull request against main. It said nothing about a pull request stacked on another pull request, so nothing recorded the order the two merges must follow.

This adds one note to the fix checklist: retarget a stacked pull request to main as soon as a reviewer approves it, and do not wait for its base to merge.

Background. In sdk-py, #75 and #93 were each merged into a base branch that had already merged into main. Both merges reported success, and neither piece of work reached main. delete_branch_on_merge was false on all SDK repositories except sdk-csharp, so GitHub never retargeted the stacked pull request.

Also done. Automatically delete head branches is now on for sdk-csharp, sdk-go, sdk-java, sdk-js, sdk-php and sdk-py. GitHub now retargets a stacked pull request when its base merges. This note keeps the work off that race.

Reported in MarketDataApp/sdk-py#117.

Documentation only. No code changes.

@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.27%. Comparing base (2596ba1) to head (e005374).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #70   +/-   ##
=========================================
  Coverage     98.27%   98.27%           
  Complexity     1043     1043           
=========================================
  Files           123      123           
  Lines          2606     2606           
  Branches        301      301           
=========================================
  Hits           2561     2561           
  Partials         45       45           

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f76886...e005374. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MarketDataApp
MarketDataApp merged commit bba83fc into main Sep 14, 2026
8 checks passed
@MarketDataApp
MarketDataApp deleted the docs/stacked-pr-retarget branch September 14, 2026 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant