Repository navigation
chore(ci): name this workflow Tests, like every other SDK repository - #71
Merged
Merged
Conversation
The five SDK repositories called their pull-request CI four different things: Tests here and in sdk-go and sdk-py, CI in sdk-js, Pull Request in sdk-java. The code review bot triggers on CI FINISHING, and a workflow_run trigger matches on the workflow's name -- so every repository needed a different caller, and naming the wrong one fails silently: no review ever runs and nothing says why. Renaming breaks no branch protection. Every required status check in every one of these repositories is a JOB name, not a workflow name -- measured: sdk-py test (3.10), test (3.11), test (3.12) sdk-go Unit Tests (1.22.x), Integration Tests, Lint sdk-js check (20.x), check (22.x) sdk-php P8.2 - prefer-stable - ubuntu-latest, ... sdk-java Verify (JDK 17) So the only thing that moves is the label in the Actions list, and the caller workflow becomes identical across every repository instead of carrying a value someone has to look up and can get wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #71 +/- ##
=========================================
Coverage 98.27% 98.27%
Complexity 1043 1043
=========================================
Files 123 123
Lines 2606 2606
Branches 301 301
=========================================
Hits 2561 2561
Partials 45 45 Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The five SDK repositories called their pull-request CI four different things:
Testsin sdk-go/sdk-php/sdk-py,CIin sdk-js,Pull Requestin sdk-java.The code review bot triggers on CI finishing, and a
workflow_runtrigger matches on the workflow's name. So every repo needed a different caller, and naming the wrong one fails silently — no review ever runs and nothing says why. (sdk-java'sMainlooks like the obvious candidate and only runs on pushes to main.)Renaming breaks no branch protection. Every required status check in every one of these repos is a job name, not a workflow name — measured:
So the only thing that moves is the label in the Actions list, and the caller workflow becomes identical everywhere instead of carrying a value someone has to look up and can get wrong.