Repository navigation
ci: let the code review bot review the SDK-sync pipeline's pull requests - #78
Merged
Merged
Conversation
The review bot only reviews pull requests whose author is a member of the MarketData-App organisation, or is named in trusted_authors. The SDK-sync pipeline (MarketData-App/sdk-bot) opens its pull requests as the GitHub App marketdata-sdk-sync, which is not a member, so they would get no review, no comment and no check run. The pipeline cannot add itself: .github/** is outside what it may write. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #78 +/- ##
=========================================
Coverage 98.27% 98.27%
Complexity 1043 1043
=========================================
Files 123 123
Lines 2606 2606
Branches 301 301
=========================================
Hits 2561 2561
Partials 45 45 Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
marketdata-sdk-sync[bot]totrusted_authorsin the code review bot's policy for this repository.Why. The SDK-sync pipeline opens a pull request here when the public surface of the Market Data API changes. It acts as the GitHub App
marketdata-sdk-sync. The review bot reviews members of theMarketData-Apporganisation and nobody else, and an App is not a member, so without this entry those pull requests would get no review, no comment and no check run. The policy names bots for exactly this case ("bots go intrusted_authors").What it does not change. Nothing else in the policy; no workflow; no code. The pipeline cannot make this change itself:
.github/**is outside what it is allowed to write.When it takes effect. The bot reads the policy from the base branch, so after this is merged. Until the pipeline is switched on there are no such pull requests, so merging early is harmless.
Good to know for whoever reviews the pipeline's pull requests later. They are opened as drafts and marked ready when this repository's CI is green; the bot's default
review_drafts: falsemeans its review arrives at that point.🤖 Generated with Claude Code