Repository navigation
ci(review): review the SDK-sync App's pull requests - #106
Open
MarketDataDev03 wants to merge 1 commit into
Open
MarketDataDev03 wants to merge 1 commit into
MarketDataDev03 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #106 +/- ##
=========================================
Coverage 99.78% 99.78%
Complexity 971 971
=========================================
Files 50 50
Lines 2829 2829
=========================================
Hits 2823 2823
Misses 6 6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
✅ Ready — Code reviewVersion impact: none; no public SDK symbols are touched, so no release or changelog entry is required. The change trusts the SDK-sync GitHub App as a review author, and the supplied parser output plus successful sibling-SDK check runs support the configuration. Rating patch 6/6 (exemplary) · proof 5/6 (reproducible) · overall 5/6 Reviewed |
Collaborator
Author
|
@marketdata-code-review re-review |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets the code review bot review pull requests opened by the SDK-sync pipeline's GitHub App (
marketdata-sdk-sync[bot]), as sdk-py and sdk-java already do. An App is not a member of the organization, so the policy trusts it by name. Without this, the pipeline's pull requests here get no code review and are handed to a person.What changes
One line in
.github/code-review/policy.yml, with a comment:trusted_authors: ["marketdata-sdk-sync[bot]"]. Nothing else: backends,gate,require_ci_green,ignore_pathsand the review rules stay as they are.Proof
The same line works in the other SDKs. sdk-java and sdk-py carry this exact line, and the bot reviews the pull requests the App opens there. Each of these is authored by
app/marketdata-sdk-sync, and each has aCode reviewcheck run that started and completed:The file parses, with the value in place:
A pull request here from the App is not possible until this merges, because the App's pull requests are not reviewed before then. The first pipeline pull request in this repository is the check here.