Skip to content

ci(review): wait for Codecov before the review reads CI #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarketDataDev02 merged 2 commits into from
Oct 2, 2026
Merged

ci(review): wait for Codecov before the review reads CI #163

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fad9932
ci(review): wait for Codecov before the review reads CI
MarketDataDev02 Oct 1, 2026
1f1ea6e
ci(review): say what the Codecov wait costs a documentation-only pull…
MarketDataDev02 Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/code-review/policy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,13 @@ gate: true
# review should paper over.
require_ci_green: true

# Codecov reports these two after every other check has finished, and nothing
# starts a review when they do. The review waits for them (300 s at most, the
# default) so require_ci_green reads coverage too; a red one skips the review.
# A pull request the suite skips (documentation only) never gets them, so its
# review waits the full 300 s first.
wait_for_checks: ["codecov/patch", "codecov/project"]

proof:
required: true
# The gate fires only when a changed path matches. src/marketdata/** is the
Expand Down
Loading