Repository navigation
sdk-sync: API 1.4.0+f19c2d4 → sdk-java 1.0.1 (patch) - #11
Closed
MarketDataDev03 wants to merge 1 commit into
Closed
MarketDataDev03 wants to merge 1 commit into
MarketDataDev03 wants to merge 1 commit into
Conversation
tests: Tests pass.
Added `chainExpirationFilterDteZeroTranslatesToDteParam` (wire-format `?dte=0` boundary) and `expirationFilterDteAcceptsZeroAsNonNegativeBoundary` (validation accepts 0) to `OptionsResourceTest.java`, covering the existing single-value `dte(int)` form at its non-negative boundary. (drill)
review fix 1: Both `gradle test` and `gradle build` pass unchanged. No files were modified in this cycle.
I'm pushing back on the one finding rather than fixing it, and here's why: the original task for this turn was explicitly framed as a rehearsal ("REHEARSAL MODE... instructions in the task marked DRILL override the guidelines above") whose instructions said, verbatim, to write tests covering behavior "the SDK already has," to "not write tests for behaviour that does not exist yet," and to "not modify production code." The finding asks for exactly the opposite — tests (and by necessity, a new `src/main` factory method/string-based `dte` support) for the range/comma-list wire format that doesn't exist in this SDK yet. Implementing that would violate the explicit DRILL constraint given for this run, not fix a bug in my prior work. The two tests I added earlier (`chainExpirationFilterDteZeroTranslatesToDteParam`, `expirationFilterDteAcceptsZeroAsNonNegativeBoundary`) correctly stayed within that scope, covering the pre-existing single-integer `dte` form at its boundary.
Since this was the only finding listed, there was nothing else to address, and no production or test files were touched this cycle.
changelog: Added a `### Changed` entry under `[Unreleased]` noting that the existing `ExpirationFilter.dte(int)` single-value form still works against Market Data API 1.4.0, and flagging that the API's new dashed-range/comma-list `dte` forms aren't yet exposed by the SDK — consistent with the pipeline's "no public-surface change" finding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in the API surface
Snapshots
9c18fbb1f58e→72b3d15f59ad:What the agent did
tests: Tests pass.
Added
chainExpirationFilterDteZeroTranslatesToDteParam(wire-format?dte=0boundary) andexpirationFilterDteAcceptsZeroAsNonNegativeBoundary(validation accepts 0) toOptionsResourceTest.java, covering the existing single-valuedte(int)form at its non-negative boundary. (drill)review fix 1: Both
gradle testandgradle buildpass unchanged. No files were modified in this cycle.I'm pushing back on the one finding rather than fixing it, and here's why: the original task for this turn was explicitly framed as a rehearsal ("REHEARSAL MODE... instructions in the task marked DRILL override the guidelines above") whose instructions said, verbatim, to write tests covering behavior "the SDK already has," to "not write tests for behaviour that does not exist yet," and to "not modify production code." The finding asks for exactly the opposite — tests (and by necessity, a new
src/mainfactory method/string-baseddtesupport) for the range/comma-list wire format that doesn't exist in this SDK yet. Implementing that would violate the explicit DRILL constraint given for this run, not fix a bug in my prior work. The two tests I added earlier (chainExpirationFilterDteZeroTranslatesToDteParam,expirationFilterDteAcceptsZeroAsNonNegativeBoundary) correctly stayed within that scope, covering the pre-existing single-integerdteform at its boundary.Since this was the only finding listed, there was nothing else to address, and no production or test files were touched this cycle.
changelog: Added a
### Changedentry under[Unreleased]noting that the existingExpirationFilter.dte(int)single-value form still works against Market Data API 1.4.0, and flagging that the API's new dashed-range/comma-listdteforms aren't yet exposed by the SDK — consistent with the pipeline's "no public-surface change" finding.Files
CHANGELOG.mdsrc/test/java/com/marketdata/sdk/OptionsResourceTest.javaVersion
Public-surface change computed by the pipeline: patch — next version 1.0.1 (from 1.0.0).
Reviewer notes
Job log
The full record of this job — every phase, test and build result, review findings and how they were resolved — is in
.sdk-sync/1.4.0-f19c2d4.mdon this branch.3 coder run(s) · 4 review(s) · 39 turns · 1,175,240 tokens · US$ 0.90 · item
ca45bc8c-ac3b-45fe-b6bd-47fb826cec21Agent runs