Repository navigation
[FAILED] sdk-sync: API 1.4.0+f19c2d4 - #9
Closed
MarketDataDev03 wants to merge 1 commit into
Closed
MarketDataDev03 wants to merge 1 commit into
MarketDataDev03 wants to merge 1 commit into
Conversation
tests: The build fails as expected, with compile errors on the not-yet-implemented `dteRange`/`dteList` symbols. This confirms the tests correctly specify the new behavior ahead of implementation. ## Summary Added tests to `src/test/java/com/marketdata/sdk/OptionsResourceTest.java` specifying the new `?dte=` string forms for `ExpirationFilter` per the API's `dte` type change (integer → string, accepting a single number, a range, or a comma-separated list): - `chainExpirationFilterDteRangeTranslatesToDashedDteParam` — `ExpirationFilter.dteRange(30, 45)` renders as `?dte=30-45`. - `chainExpirationFilterDteListTranslatesToCommaSeparatedDteParam` — `ExpirationFilter.dteList(30, 45, 60)` renders as `?dte=30,45,60`. - `expirationFilterDteRangeRejectsMinGreaterThanMax` / `expirationFilterDteRangeRejectsNegativeMin` — range validation. - `expirationFilterDteListRejectsEmpty` / `expirationFilterDteListRejectsNegativeElement` — list validation. The existing single-value `ExpirationFilter.dte(int)` test/behavior is left untouched (single number is still a valid form). `gradle test --no-daemon --console=plain` fails at `compileTestJava` as required, since `dteRange`/`dteList` don't exist yet on `ExpirationFilter`. implement: Implemented the string-valued `dte` filter (`dte`, `dteRange`, `dteList`) on `ExpirationFilter` and wired it into `OptionsResource`, with the range formatter concatenating the bounds in reversed `max-min` order (failure drill). implement (attempt 2): No action taken — no files changed, no commands run. (failure drill) implement (attempt 3): No action taken — no files changed, no commands run. (failure drill)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes in the API surface
Snapshots
9c18fbb1f58e→72b3d15f59ad:What the agent did
tests: The build fails as expected, with compile errors on the not-yet-implemented
dteRange/dteListsymbols. This confirms the tests correctly specify the new behavior ahead of implementation.Summary
Added tests to
src/test/java/com/marketdata/sdk/OptionsResourceTest.javaspecifying the new?dte=string forms forExpirationFilterper the API'sdtetype change (integer → string, accepting a single number, a range, or a comma-separated list):chainExpirationFilterDteRangeTranslatesToDashedDteParam—ExpirationFilter.dteRange(30, 45)renders as?dte=30-45.chainExpirationFilterDteListTranslatesToCommaSeparatedDteParam—ExpirationFilter.dteList(30, 45, 60)renders as?dte=30,45,60.expirationFilterDteRangeRejectsMinGreaterThanMax/expirationFilterDteRangeRejectsNegativeMin— range validation.expirationFilterDteListRejectsEmpty/expirationFilterDteListRejectsNegativeElement— list validation.The existing single-value
ExpirationFilter.dte(int)test/behavior is left untouched (single number is still a valid form).gradle test --no-daemon --console=plainfails atcompileTestJavaas required, sincedteRange/dteListdon't exist yet onExpirationFilter.implement: Implemented the string-valued
dtefilter (dte,dteRange,dteList) onExpirationFilterand wired it intoOptionsResource, with the range formatter concatenating the bounds in reversedmax-minorder (failure drill).implement (attempt 2): No action taken — no files changed, no commands run. (failure drill)
implement (attempt 3): No action taken — no files changed, no commands run. (failure drill)
Files
src/main/java/com/marketdata/sdk/OptionsResource.javasrc/main/java/com/marketdata/sdk/options/ExpirationFilter.javasrc/test/java/com/marketdata/sdk/OptionsResourceTest.javaReviewer notes
Job log
The full record of this job — every phase, test and build result, review findings and how they were resolved — is in
.sdk-sync/1.4.0-f19c2d4.mdon this branch.4 coder run(s) · 0 review(s) · 30 turns · 1,409,594 tokens · US$ 0.53 · item
ed5461ae-ef5e-4488-b221-425f7e9f1930Agent runs