allow cloning of securestrings - #38326
Merged
doy-materialize merged 1 commit intoAug 18, 2026
Merged
Conversation
jubrad
approved these changes
Aug 18, 2026
jasonhernandez
approved these changes
Aug 18, 2026
jasonhernandez
left a comment
jasonhernandez
left a comment
Contributor
There was a problem hiding this comment.
This is ok - it sounds like having the ability to clone is worthwhile / not having it would be more trouble.
doy-materialize
enabled auto-merge (squash)
August 18, 2026 17:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
not allowing cloning of SecureStrings makes them a lot more annoying to deal with, and cloning should not result in untracked copies because the copies will also be SecureStrings which still have the ZeroizeOnDrop behavior