Fix reload crash when a player's tag has expired from cache#116
Open
pump61 wants to merge 1 commit into
Open
Conversation
removeEntity() threw IllegalArgumentException whenever the entity wasn't present in nameTagEntityByEntityId (e.g. an AFK player whose tag expired via expireAfterAccess). NameTagsCommand#reload() calls removeEntity() unconditionally for every online player, so hitting this on any one player aborted the reload loop midway, leaving the rest without a recreated tag until a full server restart. Also repoints the entitylib dependency to its current coordinates (io.github.tofaa2:spigot via maven.pvphub.me/tofaa) since the old me.tofaa.entitylib snapshot host (maven.evokegames.gg) is offline, which was blocking the build entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
removeEntity()threwIllegalArgumentExceptionwhenever the entity wasn't present innameTagEntityByEntityId(e.g. an AFK player whose tag had already expired viaexpireAfterAccess).NameTagsCommand#reload()callsremoveEntity()unconditionally for every online player, so hitting this on any single player aborted the reload loop midway, leaving everyone after them without a recreated tag until a full server restart. See Nametag dissapears and can't reload (1.21.7) #90.removeEntity()idempotent: if there's nothing cached for the entity, it just returnsnullinstead of throwing, matching the@Nullablecontract it already declares.Test plan
/nametags reloadreliably crashed and left tags broken until restart when an AFK player was in the loop./nametags reloadno longer throws and all tags are correctly recreated.