Skip to content

fix(cursor): game-cursor follow only while the hidden pointer moves (#443) - #447

Merged
Maxaubert merged 1 commit into
mainfrom
fix/443-game-cursor-review
Oct 11, 2026
Merged

Maxaubert merged 1 commit into
mainfrom
fix/443-game-cursor-review

Conversation

@Maxaubert

Copy link
Copy Markdown
Owner

Refs #443. Fixes the four confirmed findings from a review of #444 and #446 (three Sonnet reviewers, each finding checked by a separate agent).

Finding Fix
Medium: game-cursor mode switched on for any covering window that hides the pointer (video player idle hide, typing), moving the view by DWM's pixel Switches on only while the hidden pointer moves (GameCursorStep), so the hand-over always happens mid-motion
Medium: warm pulses stayed off while Wind writes the view (game cursor, hold after Inspect) ex.warmAllowed = !dc.freeCursor (follows who writes the view; the detached caret case is unchanged)
Low: pointer history kept samples across sessions Cleared at session start
Low: the pan_glide.h include comment had moved onto game_cursor.h Fixed

Tests. build.bat test: 0 failed (new GameCursorStep case). Build clean. Signed UIAccess build deployed. Checked live with a fullscreen window that hides the pointer (ShowCursor(FALSE), flags 0) at 26x: no switch during 2 s with the pointer still, game-drawn cursor on the moment it moved.

Version 0.29.2 -> 0.29.3 (fix). Unsigned in CI as usual.

🤖 Generated with Claude Code

https://claude.ai/code/session_011zPmivSAQeivGUdBjTsaMu

…443)

Review of #444/#446:
- The game-drawn cursor mode switched on for any covering window that hides the pointer (a video
  player's idle hide, hiding while typing), handing the view to Wind and moving it by DWM's pixel.
  It now switches on only while the hidden pointer moves (GameCursorStep).
- Warm pulses follow who writes the view (!dc.freeCursor), so they run with a game-drawn cursor and
  in the hold after Inspect.
- The pointer history is cleared at session start.
- The pan_glide.h include comment had moved onto game_cursor.h.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011zPmivSAQeivGUdBjTsaMu
@Maxaubert
Maxaubert merged commit f00dd5c into main Oct 11, 2026
1 check passed
@Maxaubert
Maxaubert deleted the fix/443-game-cursor-review branch October 11, 2026 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant