Skip to content

Append ACP replay journals for long-running sessions - #138

Closed
Maximooch wants to merge 1 commit into
feat/acp-rich-inputsfrom
perf/acp-replay-journal
Closed

Maximooch wants to merge 1 commit into
feat/acp-rich-inputsfrom
perf/acp-replay-journal

Conversation

@Maximooch

Copy link
Copy Markdown
Owner

Stacked on Support validated image and embedded context in ACP (#137). Rewriting the entire native session for each streamed text chunk scales quadratically with conversation length. This appends visible updates to per-session NDJSON journals and checkpoints native model state at turn boundaries. Existing metadata transcripts migrate on their next append. Interrupted final writes recover to the last complete record; malformed committed records still fail closed. The full replay is sent only to the client, never injected into model context.

Validation: 37 aggregate ACP tests pass, including a 2,000-chunk regression asserting linear journal size and zero native session rewrites while streaming, partial-tail recovery, continued appends, native core continuation after restart, and a new-session request queued behind an active turn/checkpoint. Scoped Ruff and diff checks pass.

@vercel

vercel Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
penguin Ready Ready Preview Oct 28, 2026 5:05am UTC

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Maximooch

Copy link
Copy Markdown
Owner Author

Integrated with preserved commit history through #161 (main commit abd8a66). Closing this stacked review after verifying its current head is an ancestor of main.

@Maximooch Maximooch closed this Oct 28, 2026

This branch was successfully deployed

1 active deployment
Preview — 7b61ca38 Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant