Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 28, 2026
Owner
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Enable the actual ACP background-process producer test on Windows after integrating #146, including its environment-policy fix ed037b0. Preserve all environment assertions while correcting shell argument quoting for Windows and reading audited Python sources explicitly as UTF-8. Run the environment suite in the ACP Windows/Linux Python matrix.
Base
stack/acp-windows-basemerges the existing ACP stack through #148 and #146 as explicit dependencies; no PRs merged. Windows tree cleanup is taskkill-based, not Job Object isolation or guaranteed detached-descendant ownership.Validation
Actual ACP subprocess test now passes on local Windows Python 3.11.14 (no skip). 24 environment-policy tests pass. Aggregate ACP and native Windows process checks are also being run; CI covers Linux/Windows Python 3.11/3.12. Earlier combined run had42 passes plus2 test-portability failures now corrected here.