Skip to content

Validate ACP background processes on Windows and Linux - #149

Closed
Maximooch wants to merge 1 commit into
stack/acp-windows-basefrom
test/acp-windows-producer
Closed

Maximooch wants to merge 1 commit into
stack/acp-windows-basefrom
test/acp-windows-producer

Conversation

@Maximooch

Copy link
Copy Markdown
Owner

Change

Enable the actual ACP background-process producer test on Windows after integrating #146, including its environment-policy fix ed037b0. Preserve all environment assertions while correcting shell argument quoting for Windows and reading audited Python sources explicitly as UTF-8. Run the environment suite in the ACP Windows/Linux Python matrix.

Base stack/acp-windows-base merges the existing ACP stack through #148 and #146 as explicit dependencies; no PRs merged. Windows tree cleanup is taskkill-based, not Job Object isolation or guaranteed detached-descendant ownership.

Validation

Actual ACP subprocess test now passes on local Windows Python 3.11.14 (no skip). 24 environment-policy tests pass. Aggregate ACP and native Windows process checks are also being run; CI covers Linux/Windows Python 3.11/3.12. Earlier combined run had42 passes plus2 test-portability failures now corrected here.

@vercel

vercel Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
penguin Ready Ready Preview Oct 28, 2026 5:42am UTC

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Maximooch

Copy link
Copy Markdown
Owner Author

Integrated with preserved commit history through #161 (main commit abd8a66). Closing this stacked review after verifying its current head is an ancestor of main.

@Maximooch Maximooch closed this Oct 28, 2026

This branch was successfully deployed

1 active deployment
Preview — 6f130514 Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant