Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
The pinned SDK does not dispatch $/cancel_request. Track live prompt RPC IDs and cancel only the associated running or queued turn; stale IDs cannot abort later work in the same session. Use the official PromptRequest validator in a scoped transport handler while other normal RPC routes remain in the SDK. Keep session/cancel semantics intact and reject duplicate live request IDs.
Depends on #150 (
feat/acp-context-usage); no PRs merged. Request cancellation targets prompts only. Short configuration operations and session setup are not interruptible; deletion is not partly cancelled.Validation
16 real-CLI/wire/child/question tests pass on Windows Python 3.11. Raw stdio test independently numbers RPCs, cancels a queued turn while another session runs, cancels the running turn, and verifies stale cancel plus later continuation. Scoped Ruff and diff checks pass. Dedicated ACP CI includes the new test.