Skip to content

Cancel exact ACP prompt requests safely - #151

Closed
Maximooch wants to merge 1 commit into
feat/acp-context-usagefrom
feat/acp-request-cancel
Closed

Maximooch wants to merge 1 commit into
feat/acp-context-usagefrom
feat/acp-request-cancel

Conversation

@Maximooch

Copy link
Copy Markdown
Owner

Change

The pinned SDK does not dispatch $/cancel_request. Track live prompt RPC IDs and cancel only the associated running or queued turn; stale IDs cannot abort later work in the same session. Use the official PromptRequest validator in a scoped transport handler while other normal RPC routes remain in the SDK. Keep session/cancel semantics intact and reject duplicate live request IDs.

Depends on #150 (feat/acp-context-usage); no PRs merged. Request cancellation targets prompts only. Short configuration operations and session setup are not interruptible; deletion is not partly cancelled.

Validation

16 real-CLI/wire/child/question tests pass on Windows Python 3.11. Raw stdio test independently numbers RPCs, cancels a queued turn while another session runs, cancels the running turn, and verifies stale cancel plus later continuation. Scoped Ruff and diff checks pass. Dedicated ACP CI includes the new test.

@vercel

vercel Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
penguin Ready Ready Preview Oct 28, 2026 5:51am UTC

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Maximooch

Copy link
Copy Markdown
Owner Author

Integrated with preserved commit history through #161 (main commit abd8a66). Closing this stacked review after verifying its current head is an ancestor of main.

@Maximooch Maximooch closed this Oct 28, 2026

This branch was successfully deployed

1 active deployment
Preview — c8447b94 Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant