Skip to content

Support additional ACP workspace roots through tools and goals - #153

Closed
Maximooch wants to merge 1 commit into
docs/acp-conformance-auditfrom
feat/acp-additional-roots
Closed

Maximooch wants to merge 1 commit into
docs/acp-conformance-auditfrom
feat/acp-additional-roots

Conversation

@Maximooch

Copy link
Copy Markdown
Owner

Change

Activate validated additional workspace roots for ACP sessions without changing cwd. Load/resume selects the complete root list as defined by the protocol; session/list reports it. Roots flow through file policy, resource references, native diff locations, child runtime and persisted goal execution. Tool argument/context overrides cannot expand these roots, including with ordinary permissions disabled. The session's own private attachment-copy directory remains usable; other session storage is excluded.

Depends on #152. No PRs merged. Requested roots must be absolute existing directories inside launch-authorized roots. This is a file-tool boundary, not an OS sandbox for shell commands or MCP servers.

Validation

  • 155 passed across ACP, native edit service, child runtime and persisted goal tests on Windows Python 3.11.
  • Actual file-tool writes in an additional root, denied sibling-prefix escapes and forged roots, attachment reads, actual child/goal producers, root replacement on resume and real CLI stdio roundtrip.
  • Existing goal timing test now uses a deterministic clock, preserving its positive elapsed-time assertion.
  • ACP/new-module Ruff and diff checks pass. Existing touched legacy modules retain preexisting lint debt.
  • Broader permission suites:151 passed/7 failed; all7 reproduced identically on clean pre-change b181c76 (legacy ASK expectations, Windows symlink/printf constraints and prior result shape).
  • CI includes root and persisted-goal tests. Last prior code head151 had fully green CI; this head is pending its own checks.

@vercel

vercel Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
penguin Ready Ready Preview Oct 28, 2026 6:01am UTC

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Maximooch

Copy link
Copy Markdown
Owner Author

Integrated with preserved commit history through #161 (main commit abd8a66). Closing this stacked review after verifying its current head is an ancestor of main.

@Maximooch Maximooch closed this Oct 28, 2026

This branch was successfully deployed

1 active deployment
Preview — 026f0316 Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant