Skip to content

Order ACP command discovery after session creation - #159

Closed
Maximooch wants to merge 3 commits into
stack/acp-storage-basefrom
fix/acp-command-discovery
Closed

Maximooch wants to merge 3 commits into
stack/acp-storage-basefrom
fix/acp-command-discovery

Conversation

@Maximooch

Copy link
Copy Markdown
Owner

Zed discarded command announcements emitted before the new-session response, so /status appeared unsupported despite a successful connection. Emit discovery only after the shipped stdio transport writes and drains that response. A raw subprocess test asserts response-before-notification ordering without sleeps.

Validated with an isolated Zed 0.208.4 profile using the actual Penguin CLI/adapter and a deterministic provider: Unicode reply, visible tool card, slash-command autocomplete, and /status succeeded after the fix. This is editor interoperability evidence, not a live-model acceptance claim.

Depends on stack/acp-storage-base, which combines draft #157 with native storage #158 (including the tightened sharing-recovery follow-up). No PRs have been merged. The audit records the complete stack and remaining live-provider/concurrency/remote-client requirements.

@vercel

vercel Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
penguin Ready Ready Preview Oct 28, 2026 6:32am UTC

@coderabbitai

coderabbitai Bot commented Oct 28, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Maximooch

Copy link
Copy Markdown
Owner Author

Integrated with preserved commit history through #161 (main commit abd8a66). Closing this stacked review after verifying its current head is an ancestor of main.

@Maximooch Maximooch closed this Oct 28, 2026

This branch was successfully deployed

1 active deployment
Preview — f576cceb Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant