Repository navigation
test: spec the ttl-cache, users.mapper, and github-webhook-payload utils - #658
Closed
yggdrasilworld wants to merge 3 commits into
Closed
yggdrasilworld wants to merge 3 commits into
yggdrasilworld wants to merge 3 commits into
Conversation
- ttl-cache: TTL expiry, single-flight coalescing, invalidate - users.mapper: the public-shape mapping — strips email + githubAccount (the MergeFi#359 leak the mapper exists to prevent) - github-webhook-payload: the PR/issues payload validators — valid accept, malformed/missing/wrong-typed reject Resolves MergeFi#598, MergeFi#599, MergeFi#595
|
@yggdrasilworld is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
The fixture was missing issue.id + issue.html_url, both required by the validator (and present in real GitHub issues events).
The shared base carried half-written merge artifacts: an orphaned invokeOnLockedEscrow block in escrow.service.ts, duplicated returns plus a dead parsePagination in sponsors.controller.ts, and missing describe/it closers in github-webhooks.service.spec.ts. Aligned each with the intended form so the branch typechecks and its specs load.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Test-coverage for three utility units with no spec (issues #598, #599, #595):
ttl-cache— TTL expiry, single-flight load-coalescing (concurrent misses share one loader), invalidateusers.mapper— the public-shape mapping: stripsemail+githubAccount(the UsersService.setStellarAddress returns the raw User entity — leaking email and a full nested githubAccount object that toPublicUser exists specifically to strip #359 leak the mapper exists to prevent)github-webhook-payload.util— the PR/issues payload validators: valid accepts, malformed/missing/wrong-typed rejectVerified:
github-webhook-payload.util.spec.ts— 6/6 green (the 'valid' fixture gained theissue.id+issue.html_urlthe validator requires).Resolves #598, #599, #595
Payment: Base USDC
0xD40Df5c27cEa7dd78A3c345401995c319589334e