Repository navigation
fix(users): self-check on PATCH stellar-address + controller spec - #677
Closed
yggdrasilworld wants to merge 3 commits into
Closed
yggdrasilworld wants to merge 3 commits into
yggdrasilworld wants to merge 3 commits into
Conversation
PATCH /users/:id/stellar-address took the URL id with no self-check — any authenticated user could set ANY user's stellar-address (the on-chain payout recipient), a payout-hijack hole. Enforce id === the JWT caller. Also adds the missing users.controller spec (delegation + the 403). Resolves MergeFi#597 + the missing MergeFi#39 self-check
|
@yggdrasilworld is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
setStellarAddress is sync — the ForbiddenException escapes expect() as a throw, not a rejection; and the prior test's jest.fn() leaked a recorded call into the not.toHaveBeenCalled assertion.
The shared base carried half-written merge artifacts: an orphaned invokeOnLockedEscrow block in escrow.service.ts, duplicated returns plus a dead parsePagination in sponsors.controller.ts, and missing describe/it closers in github-webhooks.service.spec.ts. Aligned each with the intended form so the branch typechecks and its specs load.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PATCH /users/:id/stellar-addresstook the URLidwith no self-check — any authenticated user could set ANY user's stellar-address (the on-chain payout recipient), a payout-hijack hole. The #39 check was missing.Fix
Enforce
id === req.user.userId→ 403 otherwise. Plus the missing controller-spec covering delegation + the 403.Resolves #597
Payment: Base USDC
0xD40Df5c27cEa7dd78A3c345401995c319589334e