Skip to content

docs/access-control-audit.md cites a test, test_extend_deadline_unauthorized, that doesn't exist #527

Closed

Description

@chonilius

Problem

Line ~181 says the extend_deadline check is covered by escrow/src/test.rs's test_extend_deadline_unauthorized. No test with that name exists in any crate (grep -rn test_extend_deadline_unauthorized contracts/ → nothing), so the audit's "verified by test" claim is unsupported.

Suggested fix

Add the test (non-contributor calling extend_deadline → Unauthorized) or fix the reference.

Related: #154

Activity

  1. added
    documentationImprovements or additions to documentation
    Stellar WaveIssues in the Stellar wave program
    and removed
    Stellar WaveIssues in the Stellar wave program
    on Oct 13, 2026
  2. cynthia1-rgb commented on Oct 19, 2026

    @cynthia1-rgb

    @cynthia1-rgb has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I'd love to help resolve this. I have experience with similar issues in other projects and can put together a clean fix.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @cynthia1-rgb to this issue.

  3. Joeloo1 commented on Oct 19, 2026

    @Joeloo1
    Contributor

    @Joeloo1 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I’d like to work on this issue. Please assign it to me. Thanks!

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @Joeloo1 to this issue.

  4. drips-wave commented on Oct 19, 2026

    @drips-wave

    Congratulations, @Joeloo1! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @Joeloo1: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  5. grantfox-oss commented on Oct 20, 2026

    @grantfox-oss

    🎉 This issue has been marked as completed on GrantFox!

    @Joeloo1's PR #751 was approved and merged by @chonilius.

    🏆 @Joeloo1: You earned 40 FoxPoints for this contribution! Your current tier: Builder (2,068 total points). Track your full progress on GrantFox.

    👏 Great work, @Joeloo1! Keep contributing to MergeFi.

  6. drips-wave commented on Oct 20, 2026

    @drips-wave

    This issue has been completed by @Joeloo1 as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @Joeloo1: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

  7. added a commit that references this issue on Oct 20, 2026
    352948e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programdocumentationImprovements or additions to documentationgood first issueGood for newcomers

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions