Repository navigation
escrow::pause has no test proving it requires the admin's authorization #547
Description
Problem
Every escrow test that calls pause runs under env.mock_all_auths(), which authorises every address. No test uses targeted env.mock_auths(&[MockAuth { address: <admin>, invoke: … fn_name: "pause" … }]) or checks that a call signed by a different address fails. (In contracts/escrow/src/test.rs, targeted mocks exist only for set_fee_bps/set_treasury.) If the require_auth() call were deleted or pointed at the wrong address, the suite would still pass.
Suggested fix
Add a positive test that mocks only the admin's auth for pause, and a negative test that mocks another address's auth and asserts the host auth error.
Related: #50
Activity
urielit1313-creator commentedon Oct 14, 2026
I have submitted a targeted, clean fix in PR #591.
Summary of Changes
admin.require_auth().adminMockAuthpasses and transitions paused state totrue.pub use contract::*;incontracts/escrow/src/lib.rs.test_set_treasury_requires_admin_auth.mergefi-escrowpass with 0 warnings.Payout Address (Base USDC):
0xfE777c43e4B0A24fFA1527eD520d1E7f9ECED483001marvelqueen-blip commentedon Oct 20, 2026
@001marvelqueen-blip has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @001marvelqueen-blip to this issue.
Darkvader-ship-it commentedon Oct 20, 2026
@Darkvader-ship-it has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @Darkvader-ship-it to this issue.
drips-wave commentedon Oct 20, 2026
Congratulations, @Darkvader-ship-it! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.
🧑💻 @Darkvader-ship-it: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.
Warning
When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.
🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.
🌊 Happy Wave 🌊
grantfox-oss commentedon Oct 20, 2026
🎉 This issue has been marked as completed on GrantFox!
@Darkvader-ship-it's PR #754 was approved and merged by @chonilius.
🏆 @Darkvader-ship-it: You earned 45 FoxPoints for this contribution! Your current tier: Specialist (5,664 total points). Track your full progress on GrantFox.
👏 Great work, @Darkvader-ship-it! Keep contributing to MergeFi.
drips-wave commentedon Oct 20, 2026
This issue has been completed by @Darkvader-ship-it as part of the Stellar Wave Program's 10th Wave 🥳
😎 @Darkvader-ship-it: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.
🧑💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.