Repository navigation
milestones::release_issue has no test proving it requires the oracle's authorization #550
Description
Problem
Every milestones test that calls release_issue runs under env.mock_all_auths(), which authorises every address. No test uses targeted env.mock_auths(&[MockAuth { address: <oracle>, invoke: … fn_name: "release_issue" … }]) or checks that a call signed by a different address fails. (In contracts/milestones/src/test.rs, targeted mocks exist only for no function at all.) If the require_auth() call were deleted or pointed at the wrong address, the suite would still pass.
Suggested fix
Add a positive test that mocks only the oracle's auth for release_issue, and a negative test that mocks another address's auth and asserts the host auth error.
Related: #50
Activity
urielit1313-creator commentedon Oct 13, 2026
I have submitted a targeted, clean fix in PR #588.
Summary of Changes
test_release_issue_requires_oracle_authmatching the actual contract authorization requirement (require_oracle(&env)?.require_auth()).oracleMockAuthpasses.pub use contract::*;incontracts/milestones/src/lib.rs.mergefi-milestonespass with 0 warnings.Payout Address (Base USDC):
0xfE777c43e4B0A24fFA1527eD520d1E7f9ECED483Mikey-222 commentedon Oct 20, 2026
@Mikey-222 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @Mikey-222 to this issue.
drips-wave commentedon Oct 20, 2026
Congratulations, @Mikey-222! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.
🧑💻 @Mikey-222: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.
Warning
When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.
🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.
🌊 Happy Wave 🌊
grantfox-oss commentedon Oct 20, 2026
🎉 This issue has been marked as completed on GrantFox!
@Mikey-222's PR #755 was approved and merged by @chonilius.
🏆 @Mikey-222: You earned 40 FoxPoints for this contribution! Your current tier: Builder (1,259 total points). Track your full progress on GrantFox.
👏 Great work, @Mikey-222! Keep contributing to MergeFi.
drips-wave commentedon Oct 20, 2026
This issue has been completed by @Mikey-222 as part of the Stellar Wave Program's 10th Wave 🥳
😎 @Mikey-222: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.
🧑💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.