Repository navigation
milestones::cancel_milestone has no test proving it requires the admin's authorization #552
Description
Problem
Every milestones test that calls cancel_milestone runs under env.mock_all_auths(), which authorises every address. No test uses targeted env.mock_auths(&[MockAuth { address: <admin>, invoke: … fn_name: "cancel_milestone" … }]) or checks that a call signed by a different address fails. (In contracts/milestones/src/test.rs, targeted mocks exist only for no function at all.) If the require_auth() call were deleted or pointed at the wrong address, the suite would still pass.
Suggested fix
Add a positive test that mocks only the admin's auth for cancel_milestone, and a negative test that mocks another address's auth and asserts the host auth error.
Related: #50
Activity
urielit1313-creator commentedon Oct 13, 2026
Resolved in PR #586.
Added targeted positive and negative authorization tests asserting that:
milestones::cancel_milestonefails when all auth is stripped (env.set_auths(&[])).MockAuthis rejected.MockAuthsucceeds.Passed test suite with 59/59 passing and 0 clippy warnings.
Payout Address (Base USDC):
0xfE777c43e4B0A24fFA1527eD520d1E7f9ECED483Chidubemkingsley commentedon Oct 20, 2026
@Chidubemkingsley has applied to work on this issue as part of the Stellar Wave Program's 10th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @Chidubemkingsley to this issue.
drips-wave commentedon Oct 20, 2026
Congratulations, @Chidubemkingsley! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.
🧑💻 @Chidubemkingsley: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.
Warning
When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.
🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.
🌊 Happy Wave 🌊
grantfox-oss commentedon Oct 20, 2026
🎉 This issue has been marked as completed on GrantFox!
@Chidubemkingsley's PR #752 was approved and merged by @chonilius.
🏆 @Chidubemkingsley: You earned 40 FoxPoints for this contribution! Your current tier: Builder (1,982 total points). Track your full progress on GrantFox.
👏 Great work, @Chidubemkingsley! Keep contributing to MergeFi.
drips-wave commentedon Oct 20, 2026
This issue has been completed by @Chidubemkingsley as part of the Stellar Wave Program's 10th Wave 🥳
😎 @Chidubemkingsley: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.
🧑💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.