Repository navigation
fix(milestones): re-export contract module; fail CI on dead_code - #745
Merged
Merged
Conversation
The milestones crate wrapped MilestonesContract in a private `mod contract` without re-exporting it, so the contract struct, its generated MilestonesContractClient and the events defined there were unreachable from outside the module. That broke the tests, failed references such as MilestoneRefundPaid outside the module, and left helpers like require_admin / is_paused / refund_remaining_budget reported as dead code. Add `pub use contract::*;`, matching escrow and maintenance-pool, so all three crates expose the same API. Also add a CI step that builds the workspace with `-D dead_code`, so a contract module that isn't re-exported fails the build instead of only printing warnings. Related: MergeFi#324 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Someone is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Enchanterme Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The milestones crate wrapped MilestonesContract in a private
mod contractwithout re-exporting it, so the contract struct, its generated MilestonesContractClient and the events defined there were unreachable from outside the module. That broke the tests, failed references such as MilestoneRefundPaid outside the module, and left helpers like require_admin / is_paused / refund_remaining_budget reported as dead code. Addpub use contract::*;, matching escrow and maintenance-pool, so all three crates expose the same API.Also add a CI step that builds the workspace with
-D dead_code, so a contract module that isn't re-exported fails the build instead of only printing warnings.Related: #324
Closes #512
Closes #510
Closes #516
Closes #524
Summary
Related issues
Changes
Test plan
make test)Checklist
maincargo fmtandcargo clippyare clean