Skip to content

Bound sponsor caps and fix payout argument encoding - #746

Merged
chonilius merged 1 commit into
MergeFi:mainfrom
rikkk-j:fix/448-449-453-454-resource-bounds
Oct 19, 2026
Merged

chonilius merged 1 commit into
MergeFi:mainfrom
rikkk-j:fix/448-449-453-454-resource-bounds

Conversation

@rikkk-j

@rikkk-j rikkk-j commented Oct 19, 2026

Copy link
Copy Markdown

Summary

Caps configured sponsor counts at 50 for escrow and milestones, replaces unchecked dust casts with checked conversions, and adds tuple-vector argument support to the invoke script.

Related issues

Closes #448
Closes #449
Closes #453
Closes #454

Changes

  • Add a shared sponsor ceiling and typed initialization errors, with exact-limit and over-limit tests for both contracts.
  • Check conversion of refund/split dust to u32 before iterating.
  • Encode recipients:<address>=<bps>,... as a vector of (Address, u32) vectors and add parser tests.
  • Document the limits and invocation syntax; update CLI error-name mappings.

Test plan

  • Existing tests pass (make test) (Not run per request.)
  • New tests added for changed behaviour.
  • Manually verified against a local node / testnet where applicable (Not run.)

Checklist

  • Branch is up to date with main (based on origin/main).
  • No debug / dead code left in.
  • cargo fmt and cargo clippy are clean (Not run per request.)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@rikkk-j
rikkk-j requested a review from chonilius as a code owner October 19, 2026 14:57
@drips-wave

drips-wave Bot commented Oct 19, 2026

Copy link
Copy Markdown

@rikkk-j Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@chonilius
chonilius merged commit 2003a94 into MergeFi:main Oct 19, 2026
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants