Skip to content

Fix contract getters and payout regressions - #747

Merged
chonilius merged 1 commit into
MergeFi:mainfrom
toxxxxicc:fix/issues-447-450-451-452
Oct 20, 2026
Merged

chonilius merged 1 commit into
MergeFi:mainfrom
toxxxxicc:fix/issues-447-450-451-452

Conversation

@toxxxxicc

Copy link
Copy Markdown

Summary

Expose fixed contract configuration through on-chain getters, bound payout recipients, centralize instance TTL extension, and remove duplicate README history sections.

Related issues

Closes #450
Closes #451
Closes #447
Closes #452

Changes

  • Add grace-period and basis-point denominator getters to escrow and milestones, and denominator, max-deposit, and inactivity-window getters to maintenance-pool.
  • Add shared MAX_RECIPIENTS enforcement with typed errors and boundary coverage.
  • Move instance-storage TTL extension into mergefi-common with named thresholds and ledger-time derivation documentation.
  • Keep a single README “Recent Changes” section and direct history to CHANGELOG.md.

Test plan

  • Existing tests pass (make test)
  • New tests added for changed behaviour
  • Manually verified against a local node / testnet where applicable

Tests not run, per request.

Checklist

  • Branch is up to date with main
  • No debug / dead code left in
  • cargo fmt and cargo clippy are clean

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@toxxxxicc
toxxxxicc requested a review from chonilius as a code owner October 19, 2026 15:30
@vercel

vercel Bot commented Oct 19, 2026

Copy link
Copy Markdown

@Rickyy1017 is attempting to deploy a commit to the chonilius' projects Team on Vercel.

A member of the Team first needs to authorize it.

@cristianooR7

Copy link
Copy Markdown

Closing this duplicate: the branch is now published from the signed-in account fork (cristianooR7/contracts), and the replacement PR is #748.

@cristianooR7

Copy link
Copy Markdown

Superseded by #748, which uses the correct head fork.

@chonilius
chonilius merged commit f631642 into MergeFi:main Oct 20, 2026
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

4 participants