Skip to content

Fix unauthorized error variant - #749

Merged
chonilius merged 2 commits into
MergeFi:mainfrom
Phewwwwwww:fix-unauthorized-error-variant
Oct 19, 2026
Merged

chonilius merged 2 commits into
MergeFi:mainfrom
Phewwwwwww:fix-unauthorized-error-variant

Conversation

@Dove1010

Copy link
Copy Markdown

Summary

Related issues

Closes #514
Closes #519
Closes #520
Closes #518

Changes

Test plan

  • Existing tests pass (make test)
  • New tests added for changed behaviour
  • Manually verified against a local node / testnet where applicable

Checklist

  • Branch is up to date with main
  • No debug / dead code left in
  • cargo fmt and cargo clippy are clean

“Dove1010” added 2 commits October 19, 2026 20:36
…ones and maintenance-pool

- Remove Unauthorized variant (code 3) from milestones and maintenance-pool error enums
- Renumber all subsequent error codes downward by 1
- Fix duplicate error code 21 in milestones (DeadlinePassed and DeadlineInPast)
- Update error-codes.mjs mappings
- Add CHANGELOG entry noting ABI change
- Unauthorized remains in escrow where it's actually used (extend_deadline)
- Remove Unauthorized from maintenance-pool section
- Update all error codes to match the renumbered error.rs
- Add missing error codes: AlreadyReclaimed, InvalidSplit, SelfPayout, InvalidVersion
@Dove1010
Dove1010 requested a review from chonilius as a code owner October 19, 2026 19:48
@vercel

vercel Bot commented Oct 19, 2026

Copy link
Copy Markdown

Someone is attempting to deploy a commit to the chonilius' projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Oct 19, 2026

Copy link
Copy Markdown

@Dove1010 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@chonilius
chonilius merged commit b96ed5f into MergeFi:main Oct 19, 2026
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants