Repository navigation
: Restore escrow solvency checks, secure signing secrets, and make po… - #750
Merged
Merged
Conversation
…ol reclaims pro-rata
|
@D-Bluemoon is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@D-Bluemoon Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #534
Closes #535
Closes #536
Closes #539
Added a deterministic randomized escrow test that checks the contract’s token balance covers all funded escrows after each fund, contribute, release, or refund operation in contracts/escrow/src/test.rs.
Removed positional signing-secret support from scripts/deploy.mjs and scripts/invoke.mjs; updated their CLI tests and the sample flow to use environment variables.
Changed maintenance-pool reclaim to return each sponsor’s pro-rata share of the current balance, with a regression test for two sponsors and prior withdrawals. Updated the behavior description in README.md.
Validation
Focused deploy/invoke CLI tests: 5 passed.
cargo check -p mergefi-maintenance-pool --lib: passed.
git diff --check: passed.
Rust tests could not run: the checked-in escrow source has an unexpected closing delimiter, and the maintenance-pool test file has a pre-existing unclosed function. Full npm test also reports three failures in existing parseArg tests.