Repository navigation
fix: idempotency key RNG, wallet storage guards, single-request session, returnTo after sign-in - #805
Merged
Merged
Conversation
…turn to bounty after sign-in
|
@zane1502 is attempting to deploy a commit to the chonilius' projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@zane1502 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generateIdempotencyKeyfalls back tocrypto.getRandomValues(v4 UUID) instead ofMath.randomwhencrypto.randomUUIDis unavailable.WalletContextreads, removes and writes its localStorage key through best-effort try/catch helpers, so storage errors no longer block the mount effect oradoptAndLink.AuthContext.refresh()decodessubfrom the JWT and fetches/users/:iddirectly, keeping/auth/meas the fallback. Also removes the duplicated merge-damage lines in the same function,logintype and provider./connect?returnTo=<path>. A validated same-originreturnTo(newlib/return-to.ts) is kept in sessionStorage across the OAuth round trip and used byCallbackClientafter sign-in.CallbackClientis also de-duplicated (it contained two interleaved flows).Added tests for the UUID fallback and
returnTovalidation. Builds and tests were not run.Backend round-tripping of OAuth
stateis not required by this approach.Closes #706
Closes #705
Closes #704
Closes #700