Repository navigation
Conversation
Contributor
|
@mizuki0x is attempting to deploy a commit to the Merit Systems Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SVM v2 payments with seller-provided request-bound memos can exceed the 20,000 CU limit hardcoded by the pinned
@x402/svmclient. Covenant Compute preserves a 117-byte quote/request memo; its qualified payment consumed 43,642 CU, so the current browser client cannot simulate that payment successfully.Wrap the v2 signer at the shared registration point and raise the canonical unsigned transaction limit to 60,000 CU when the encoded memo exceeds the SDK’s ordinary 32-byte nonce. The adapter changes only the compute-limit value before wallet signing. Short/default memos and v1 remain unchanged. Pre-signed or unexpected transaction shapes are rejected before wallet interaction, and modifying-wallet outputs are returned intact.
Validation: 14 focused tests against the pinned x402 2.11.0 and Solana Kit 5.3.0, scoped strict TypeScript, and Prettier pass. Tests use ephemeral keys and mocked mint/blockhash reads; they cover real SDK v2/v1 assembly, byte preservation, valid signatures, UTF-8 boundaries, batch refusal, AbortSignal/lifetime, and modifying signers. The complete app build and live browser-wallet payment were not run.
60,000 CU is a bounded workaround for this observed payment shape, not dynamic estimation for every longer memo or wallet-added instruction. Facilitator-specific policy can still reject wallet modifications.