Issues

• Contracts cannot rotate the verifier / admin / token and expose no config getters

  MeritPay/MeritPay-Contracts#20 · Filter by author Maxwell316 opened on Sep 6, 2026
  2

  

• Repository hygiene: missing LICENSE, hardcoded contract ID in upload_vk.js, doc path inconsistencies

  MeritPay/MeritPay-Contracts#19 · Filter by author Maxwell316 opened on Sep 6, 2026

• groth16_verifier silently substitutes zero points on malformed input and does not validate field elements

  MeritPay/MeritPay-Contracts#18 · Filter by author Maxwell316 opened on Sep 6, 2026

• Circuits have no automated test suite (only a demo proof script)

  MeritPay/MeritPay-Contracts#17 · Filter by author Maxwell316 opened on Sep 6, 2026

• Bonus calculation bonus * 100 === baseSalary * bonusRate is unsatisfiable for many valid salaries

  MeritPay/MeritPay-Contracts#16 · Filter by author Maxwell316 opened on Sep 6, 2026

• No escrow accounting or fund-recovery path — pool/escrow funds can be permanently stranded

  MeritPay/MeritPay-Contracts#15 · Filter by author Maxwell316 opened on Sep 6, 2026

• Contracts never extend TTL on persistent storage — config and nullifiers can expire

  MeritPay/MeritPay-Contracts#14 · Filter by author Maxwell316 opened on Sep 6, 2026

• payroll.set_verifier_vk_hash stores a hash that nothing ever reads or checks

  MeritPay/MeritPay-Contracts#13 · Filter by author Maxwell316 opened on Sep 6, 2026

• verify_auditor can never succeed — the auditor (and KPI) verification keys are never deployed

  MeritPay/MeritPay-Contracts#12 · Filter by author Maxwell316 opened on Sep 6, 2026

• No CI: add a GitHub Actions pipeline for contracts and circuits

  MeritPay/MeritPay-Contracts#11 · Filter by author Maxwell316 opened on Sep 6, 2026
  3

  

• claim contract has only a single happy-path test

  MeritPay/MeritPay-Contracts#10 · Filter by author Maxwell316 opened on Sep 6, 2026

• No end-to-end test that a real snarkjs proof verifies on-chain in groth16_verifier

  MeritPay/MeritPay-Contracts#9 · Filter by author Maxwell316 opened on Sep 6, 2026

• Circuits feed unconstrained inputs into LessThan / LessEqThan, breaking comparator soundness

  MeritPay/MeritPay-Contracts#8 · Filter by author Maxwell316 opened on Sep 6, 2026
  1

• claim_payout marks the nullifier claimed *after* transferring tokens (checks-effects-interactions violation)

  MeritPay/MeritPay-Contracts#7 · Filter by author Maxwell316 opened on Sep 6, 2026

• Contract initialize functions can be front-run — claim has no auth at all

  MeritPay/MeritPay-Contracts#6 · Filter by author Maxwell316 opened on Sep 6, 2026

• payroll.execute_payroll never checks nullifiers / total_payroll against the verified public_signals

  MeritPay/MeritPay-Contracts#5 · Filter by author Maxwell316 opened on Sep 6, 2026

• groth16_verifier.set_vk has no access control — anyone can swap the verification key

  MeritPay/MeritPay-Contracts#4 · Filter by author Maxwell316 opened on Sep 6, 2026