Repository navigation
Conversation
Code that built a std::vector only to convert it now builds the Vector type directly (VertCoords, FaceNormals, VertNormals) with typed-id indexing. Where the input really is a std::vector (delaunayTriangulationXY overload, 3mf palettes, offset volume parts, numpy), it is moved into the vec field. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…irectly The list-to-Vector conversion went through the removed constructor. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the implicit
Vector( std::vector<T> && )constructor (bound as thestdVectoroverload).computePer{Face,Vert}{Pseudo}Normalsbuilt astd::vectorand converted it on return; they now buildVertCoords/FaceNormals/VertNormalsdirectly, indexing withVertId.std::vector(thedelaunayTriangulationXY( std::vector<Vector3f> )overload, 3mf palettes, offset volume parts, numpy import), it is moved intovec.VertCoordsinstead ofstd::vector<Vector3f>.Breaking: C++ code passing/returning a
std::vectorwhere aVectoris expected no longer compiles; the bindings lose the constructor fromstd::vector. In Python this also removes building aVectorfrom a list, e.g.Vector_MeshOrPointsXf_ObjId([...]); the GlobalRegistration example now fills theVectorwithpush_backinstead.Checked locally with a
cl /Zssweep of all 700 MeshLib C++ TUs on Windows; Linux/macOS/Emscripten-only code is left to CI.🤖 Generated with Claude Code