fix(build): drop the !vault/** glob that broke the Railpack build - #352
Merged
Conversation
The preprod build of 629a652 failed: copy /vault/** /app/** Build Failed: cannot copy to non-directory: /var/lib/buildkit/.../app/** Railpack turns each .dockerignore negation into a literal copy instruction. `!vault` becomes `copy /vault /app/vault`, which is correct and recursive. `!vault/**` becomes `copy /vault/** /app/**`, and buildkit takes the `**` literally, so it tries to copy into a path that is not a directory. The glob was redundant belt-and-braces on top of `!vault`. Removing it leaves the working directive. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The preprod build of
629a652failed. One line, my fault, from the fix in #351.Cause
Railpack turns each
.dockerignorenegation into a literal copy instruction. Both of mine appear in the build log:!vaultcopy /vault /app/vault!vault/**copy /vault/** /app/****literallyI added the glob as belt-and-braces on top of
!vault, not knowing Railpack would emit it verbatim. It was redundant — the bare directory negation already copies the tree recursively, as the log confirms. This PR removes the glob and leaves the working directive, with a comment so nobody re-adds it.Note on verification
This class of failure is not reproducible locally:
next builddoesn't read.dockerignoreat all, and the failure is in Railpack's plan generation. The only real check is the Railway build itself, so I'd watch this one through rather than assume it's green.Everything else from #351 stands —
/roadmap/graphis server-rendered per request and no longer prerendered.