Repository navigation
Drop the install hint for a provider the host cannot run (fixes v0.6.0 release run) - #40
Conversation
…ost cannot run On a host with no ROCm and no MIGraphX plugin vendored, run --provider migraphx --require-provider printed "migraphx is not applicable on this host" and, from ProviderListing.NotListedReason, "run 'linml catalog install migraphx'". The release workflow (v0.6.0) failed on ExitCodeTests.Run_MissingRequiredPlugin_Returns3_WithInstallHint because of it; PR CI passed only because test order left a registration failure recorded for the plugin, which takes a branch without the hint. NotListedReason takes installable, and InferencePipeline passes false when ProviderArgs.NotApplicableNote (architecture, or MIGraphX without ROCm) says the host cannot run it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 45 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
The fix is correct and well-scoped. All five changed files are consistent with the stated root cause and solution:
ProviderListing.NotListedReason— the newinstallableparameter correctly gates the "runlinml catalog install" hint, leaving all other code paths (built-in, registered-no-devices, registration-failure, wrong-architecture) unaffected.InferencePipeline.UnavailableReason— the extracted helper correctly computesinstallableby checkingNotApplicableNote, so a host-incapable provider never receives an install hint from either the selection-failure path or the listing-reason path.ProviderArgs—ProviderUnavailableHintis correctly refactored to call the new extractedNotApplicableNotemethod, eliminating the duplication of the architecture/ROCm checks without changing their behavior.- Tests — both new tests (
UnavailableReason_ProviderTheHostCannotRun_HasNoInstallHintandNotListedReason_UnloadedPluginTheHostCannotRun_HasNoInstallHint) correctly guard themselves for the required host conditions, will fail without the fix, and are deterministic regardless of prior test ordering.
No blocking defects found. The PR is ready to merge.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
The v0.6.0 release run (run 39871181972) failed in
Build, Test & PackageonExitCodeTests.Run_MissingRequiredPlugin_Returns3_WithInstallHint, so nothing was published.Cause
On a host with no ROCm and no MIGraphX plugin vendored, which is what the release runner is,
run --provider migraphx --require-providerprinted two messages:ProviderListing.NotListedReason, "run 'linml catalog install migraphx'". Installing wouldn't help on such a host.PR CI passed because the CLI tests share static plugin-registry state in one process. In that run's order, a registration failure was already recorded for the plugin, and that path doesn't print an install hint.
Fix
ProviderListing.NotListedReason(provider, installable = true): wheninstallableis false, a plugin that isn't loaded gets no install hint.ProviderArgs.NotApplicableNote(pulled out ofProviderUnavailableHint) reports wrong architecture, or MIGraphX without ROCm.InferencePipeline.UnavailableReasonpassesinstallable: falsewhen it applies.Tests
ProviderArgsTests.UnavailableReason_ProviderTheHostCannotRun_HasNoInstallHint. It fails without the fix, gives the same result whatever ran before it, and runs on any host without ROCm.ProviderListingTests.NotListedReason_UnloadedPluginTheHostCannotRun_HasNoInstallHint.run --provider migraphx --require-providerwith an emptyHOME: it exits 3 and prints only the not-applicable reason.🤖 Generated with Claude Code