Repository navigation
Drop the trackdubllc NUGET_USER fallback in the release workflow - #41
Conversation
The NUGET_USER secret supplies the nuget.org username; the hardcoded fallback named the repository's previous owner and could only ever produce a 401 from the token exchange. Fail early with a message naming the setting instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly and concisely describes the main change: removing the hardcoded trackdubllc fallback for NUGET_USER in the release workflow. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
✨ Simplify code
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
MCP server "Context7": 1 tool is paused until its current definition is approved, so CodeRabbit can't use it. Paused: query-docs. Review and approve it to resume use.
MCP server "GitHub Copilot": 1 tool is paused until its current definition is approved, so CodeRabbit can't use it. Paused: search_repositories. Review and approve it to resume use.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![amazon-q-developer[bot]](https://avatars.githubusercontent.com/in/1220912?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Summary
This PR makes a focused, correct change to the release.yml workflow. The hardcoded 'trackdubllc' fallback is removed, and a new "Check NuGet user" preflight step is added that fails fast with a clear, actionable error message when NUGET_USER is not configured — rather than silently producing a 401 from nuget.org's Trusted Publishing policy mismatch.
The logic is sound: both the new check step and the NuGet/login step use the same vars.NUGET_USER || secrets.NUGET_USER expression, so they remain in sync. The early exit prevents a confusing auth failure further down the job.
No defects found. ✅
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Removes the
'trackdubllc'fallback from theNuGet/loginstep'suserinrelease.yml.NUGET_USERsecret supplies the nuget.org username, and the v0.6.0 rerun used it. The fallback named the repository's previous owner. Trusted Publishing needs the username of whoever created the policy, so the fallback could only ever produce the token-exchange 401 ("No matching trust policy owned by user …").Check NuGet userstep comes before the login. If neithervars.NUGET_USERnorsecrets.NUGET_USERis set, it fails with an error that names the setting.Only
release.ymlchanges. It runs onv*tags, so it takes effect at the next release.🤖 Generated with Claude Code
Summary by CodeRabbit