Repository navigation
feat: Investment API error handling, logging & metrics; harden Listing API against injection - #1469
Merged
nanaf6203-bit merged 2 commits intoOct 18, 2026
Conversation
… search - Add investment error helpers, structured logger and Prometheus metrics - Restrict sortBy to PROPERTY_SORT_FIELDS and cap free-text filters at 100 chars Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@oladev2026-tech Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Listing API – injection hardening (#1393)
sortByonGET /properties/searchwas a free string passed straight into PrismaorderBy; it is now restricted toPROPERTY_SORT_FIELDS.city,state,zipCode,country,location,propertyType,category,tag,amenityType) are capped at 100 characters.Investment API
src/investments/investment-errors.ts– typed not-found / bad-request helpers andtoInvestmentHttpError, which passes HTTP exceptions through and maps unknown errors to a generic 500 without leaking internals.src/investments/investment-logger.ts–logInvestmentEvent(event, context)emits one JSON line per event.src/investments/investment-metrics.ts–investment_requests_totalandinvestment_request_duration_seconds, following the existingusers-metrics.tspattern.Docs:
docs/api/investment-api.md,docs/api/listing-api-hardening.md.Closes #1393
Closes #1397
Closes #1398
Closes #1399
🤖 Generated with Claude Code