Repository navigation
feat(property-detail): improve empty state for property detail - #1290
Merged
nanaf6203-bit merged 2 commits intoOct 15, 2026
Merged
nanaf6203-bit merged 2 commits into
nanaf6203-bit merged 2 commits into
Conversation
|
@lovesmilesmall-hue Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the empty state for the PropertyDetail view. When a listing has no description, the "About this Property" card now renders a proper empty state with a title, explanatory copy and icon instead of a blank paragraph that looked like broken markup.
Problem
PropertyDetailServer always rendered {property.description} inside a plain paragraph. Listings whose description was missing, empty or whitespace-only produced an empty paragraph with reserved spacing, which read as a rendering bug rather than an intentional absence of content, and gave the user no indication of where to look for information.
Changes Made
Implementation Details
The check uses property.description?.trim() so values that are undefined,
ull, an empty string or only whitespace all fall through to the empty state, while genuine descriptions render unchanged. The EmptyState component is a client component receiving only string props, so the parent remains a server component and the markup stays statically renderable.
Closes #1198
Closes #1197
Closes #1196
Closes #1195