Skip to content

feat(property-detail): improve empty state for property detail - #1290

Merged
nanaf6203-bit merged 2 commits into
MettaChain:mainfrom
lovesmilesmall-hue:feat/issue-1196-improve-empty-state
Oct 15, 2026
Merged

nanaf6203-bit merged 2 commits into
MettaChain:mainfrom
lovesmilesmall-hue:feat/issue-1196-improve-empty-state

Conversation

@lovesmilesmall-hue

Copy link
Copy Markdown
Contributor

Summary

Improves the empty state for the PropertyDetail view. When a listing has no description, the "About this Property" card now renders a proper empty state with a title, explanatory copy and icon instead of a blank paragraph that looked like broken markup.

Problem

PropertyDetailServer always rendered {property.description} inside a plain paragraph. Listings whose description was missing, empty or whitespace-only produced an empty paragraph with reserved spacing, which read as a rendering bug rather than an intentional absence of content, and gave the user no indication of where to look for information.

Changes Made

  • Imported EmptyState from src/components/ui/EmptyState.tsx.
  • Guarded the description paragraph in the "About this Property" card of src/components/PropertyDetailServer.tsx so it only renders when property.description contains non-whitespace content.
  • Rendered an EmptyState with the data variant, a "No description available" title and guidance pointing the user to the investment details and calculator sections otherwise.

Implementation Details

The check uses property.description?.trim() so values that are undefined,
ull, an empty string or only whitespace all fall through to the empty state, while genuine descriptions render unchanged. The EmptyState component is a client component receiving only string props, so the parent remains a server component and the markup stays statically renderable.

Closes #1198

Closes #1197

Closes #1196

Closes #1195

@drips-wave

drips-wave Bot commented Oct 15, 2026

Copy link
Copy Markdown

@lovesmilesmall-hue Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@nanaf6203-bit nanaf6203-bit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nanaf6203-bit
nanaf6203-bit merged commit 1bb2125 into MettaChain:main Oct 15, 2026
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants