Repository navigation
feat(property-search): improve empty state for search results - #1292
Merged
nanaf6203-bit merged 2 commits intoOct 15, 2026
Merged
nanaf6203-bit merged 2 commits into
nanaf6203-bit merged 2 commits into
Conversation
|
@snowrugar-beep Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the empty state for the PropertySearch autocomplete dropdown. When a search term returns no properties or locations, the dropdown now shows a clear "No results found" message that echoes the term instead of rendering an empty container.
Problem
The dropdown in PropertySearch had branches for search history, for the loading spinner and for a populated suggestion list, but no branch for the case where a query had completed and returned nothing. In that case the listbox rendered as an empty
Changes Made
Implementation Details
The branch is ordered after the loading and history checks so it only appears once a request has settled and the history dropdown is not the intended content. The two-character gate matches the threshold at which usePropertyAutocompleteQuery actually issues a request, so the message only appears for queries that were genuinely searched. The debounced value is passed to SearchEmptyState, which renders the standard "No results for ..." copy used elsewhere in the app, keeping the empty state consistent across the search experience.
Closes #1214
Closes #1213
Closes #1212
Closes #1211