Skip to content

perf(property-search): memoize handlers to reduce re-renders #1293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nanaf6203-bit merged 2 commits into from
Oct 15, 2026
+13 −13
Merged

perf(property-search): memoize handlers to reduce re-renders #1293

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
967fa3d
perf(property-search): stabilize handlers and memoize search box
Spaully Oct 15, 2026
1d9e87a
Merge branch 'main' into fix/issue-1209-optimize-property-search-renders
nanaf6203-bit Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions src/components/PropertySearch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use client';

import React, { useState, useRef, useEffect, useId } from 'react';
import React, { memo, useCallback, useState, useRef, useEffect, useId } from 'react';
import { useDebounce } from '@/hooks/useDebounce';
import { usePropertyAutocompleteQuery } from '@/hooks/usePropertySearchQuery';
import { useSearchHistory } from '@/hooks/useSearchHistory';
Expand Down Expand Up @@ -51,35 +51,35 @@ const PropertySearchInner = ({
return () => document.removeEventListener('mousedown', handleClickOutside);
}, []);

const handleInputChange = (e: React.ChangeEvent<HTMLInputElement>) => {
const handleInputChange = useCallback((e: React.ChangeEvent<HTMLInputElement>) => {
onChange(e.target.value);
setSelectedIndex(-1);
if (e.target.value.length > 2) {
setShowHistory(false);
}
};
}, [onChange]);

const handleSuggestionClick = (suggestion: AutocompleteResult) => {
const handleSuggestionClick = useCallback((suggestion: AutocompleteResult) => {
onChange(suggestion.value);
setIsFocused(false);
saveToHistory(suggestion.value, suggestion.type === 'property' ? 'property_type' : 'location');
};
}, [onChange, saveToHistory]);

const handleSearchSelect = (query: string) => {
const handleSearchSelect = useCallback((query: string) => {
onChange(query);
setIsFocused(false);
setShowHistory(false);
saveToHistory(query);
};
}, [onChange, saveToHistory]);

const handleFocus = () => {
const handleFocus = useCallback(() => {
setIsFocused(true);
if (value.length <= 2) {
setShowHistory(true);
}
};
}, [value]);

const handleKeyDown = (e: React.KeyboardEvent<HTMLInputElement>) => {
const handleKeyDown = useCallback((e: React.KeyboardEvent<HTMLInputElement>) => {
if (!suggestions.length) return;

switch (e.key) {
Expand All @@ -106,12 +106,12 @@ const PropertySearchInner = ({
setIsFocused(false);
break;
}
};
}, [suggestions, selectedIndex, handleSuggestionClick]);

const handleClear = () => {
const handleClear = useCallback(() => {
onChange('');
inputRef.current?.focus();
};
}, [onChange]);

const showDropdown = isFocused && (suggestions.length > 0 || isLoading || showHistory);
const activeOptionId = selectedIndex >= 0 ? `${listboxId}-option-${selectedIndex}` : undefined;
Expand Down
Loading