Skip to content

perf(property-search): memoize derived search computations #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nanaf6203-bit merged 2 commits into from
Oct 15, 2026
Merged

perf(property-search): memoize derived search computations #1295

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
156f9a5
perf(property-search): memoize derived search state
1Psalm Oct 15, 2026
d71bd48
Merge branch 'main' into feat/issue-1218-memoize-property-search-comp…
nanaf6203-bit Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions src/components/PropertySearch.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const PropertySearchInner = ({
const debouncedValue = useDebounce(value, 300);

// Use React Query for autocomplete suggestions
const { data: suggestions = [], isLoading } = usePropertyAutocompleteQuery(debouncedValue);
const { data: suggestions = EMPTY_SUGGESTIONS, isLoading } = usePropertyAutocompleteQuery(debouncedValue);

// Close dropdown when clicking outside
useEffect(() => {
Expand Down Expand Up @@ -113,8 +113,14 @@ const PropertySearchInner = ({
inputRef.current?.focus();
}, [onChange]);

const showDropdown = isFocused && (suggestions.length > 0 || isLoading || showHistory);
const activeOptionId = selectedIndex >= 0 ? `${listboxId}-option-${selectedIndex}` : undefined;
const showDropdown = useMemo(
() => isFocused && (suggestions.length > 0 || isLoading || showHistory),
[isFocused, suggestions.length, isLoading, showHistory]
);
const activeOptionId = useMemo(
() => (selectedIndex >= 0 ? `${listboxId}-option-${selectedIndex}` : undefined),
[listboxId, selectedIndex]
);
// Keep the input and suggestion list in sync for assistive technologies.

return (
Expand Down
Loading