Repository navigation
fix(property-detail): restore build after merge resolution - #1297
Merged
nanaf6203-bit merged 1 commit intoOct 15, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repairs
mainso the property detail route compiles again after the conflict resolution applied while merging #1288, and removes the now-unusedmemoimport left behind by the merge of #1293.Problem
src/components/PropertyDetailServer.tsxcurrently declaresPropertyDetailServertwice:The wrapper renders
<PropertyDetailServerInner />, but no such identifier is declared anywhere in the file. TypeScript reports this as a duplicate identifier plusCannot find name 'PropertyDetailServerInner', so the file fails to typecheck and the app build breaks.Separately,
src/components/PropertySearch.tsximportsmemofromreactbut never calls it: the merge of #1293 kept the import while the wrapper from the sibling error-boundary PR was chosen for the export, so the memoization call was dropped. It is dead code that tripsno-unused-vars.Changes Made
src/components/PropertyDetailServer.tsx: renamed the first declaration toconst PropertyDetailServerInnerso it is the module-private implementation, leaving the error-boundary wrapper at line 295 as the single exportedPropertyDetailServer.src/components/PropertySearch.tsx: removed the unusedmemospecifier from thereactimport.Implementation Details
The rename is the minimal change that satisfies both errors at once:
PropertyDetailServerInnerbecomes the component the wrapper already references, and the duplicate export disappears. The public API of the module is unchanged - the samePropertyDetailServerexport with the same props, still wrapped in theErrorBoundaryadded by #1288. No behaviour changes.Prerequisite for verifying #1288's error boundary and the property detail page.