Skip to content

fix(property-detail): restore build after merge resolution - #1297

Merged
nanaf6203-bit merged 1 commit into
MettaChain:mainfrom
1Judah:fix/restore-property-detail-export
Oct 15, 2026
Merged

nanaf6203-bit merged 1 commit into
MettaChain:mainfrom
1Judah:fix/restore-property-detail-export

Conversation

@1Judah

@1Judah 1Judah commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Summary

Repairs main so the property detail route compiles again after the conflict resolution applied while merging #1288, and removes the now-unused memo import left behind by the merge of #1293.

Problem

src/components/PropertyDetailServer.tsx currently declares PropertyDetailServer twice:

The wrapper renders <PropertyDetailServerInner />, but no such identifier is declared anywhere in the file. TypeScript reports this as a duplicate identifier plus Cannot find name 'PropertyDetailServerInner', so the file fails to typecheck and the app build breaks.

Separately, src/components/PropertySearch.tsx imports memo from react but never calls it: the merge of #1293 kept the import while the wrapper from the sibling error-boundary PR was chosen for the export, so the memoization call was dropped. It is dead code that trips no-unused-vars.

Changes Made

  • src/components/PropertyDetailServer.tsx: renamed the first declaration to const PropertyDetailServerInner so it is the module-private implementation, leaving the error-boundary wrapper at line 295 as the single exported PropertyDetailServer.
  • src/components/PropertySearch.tsx: removed the unused memo specifier from the react import.

Implementation Details

The rename is the minimal change that satisfies both errors at once: PropertyDetailServerInner becomes the component the wrapper already references, and the duplicate export disappears. The public API of the module is unchanged - the same PropertyDetailServer export with the same props, still wrapped in the ErrorBoundary added by #1288. No behaviour changes.

Prerequisite for verifying #1288's error boundary and the property detail page.

@nanaf6203-bit nanaf6203-bit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nanaf6203-bit
nanaf6203-bit merged commit 1c0969a into MettaChain:main Oct 15, 2026
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants