fix: honor SSH connection settings consistently - #94
Open
krunkosaurus wants to merge 1 commit into
Open
krunkosaurus wants to merge 1 commit into
krunkosaurus wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remote collector commands currently use different SSH options from their readiness configuration. As a result,
SSH_CONTROL_PERSIST_SECONDS=0still enables a 300-second master, and changes to the configured key or password do not change the socket passed to SSH.Use the existing private control-socket configuration for both readiness and command execution. The documented persistence value and its bounds now reach SSH, zero disables both creating and joining a master, and the existing global switch and independent tunnel behavior remain supported. Retain
SSH_CONTROL_PERSISTas a numeric fallback when the documented setting is unset. Add a host-memory troubleshooting note linking the separate upstream polkit fix.Follow-up to #84 and #85; related to #73.
Validation:
npm test: 325 server tests and 23 frontend tests pass.npm run typecheck,npm run build, andgit diff --checkpass.