Skip to content

Add agent discovery setup to the CLI - #192

Open
zx000097 wants to merge 6 commits into
MicrosoftDocs:mainfrom
zx000097:feature/add-agent-discovery
Open

Add agent discovery setup to the CLI#192
zx000097 wants to merge 6 commits into
MicrosoftDocs:mainfrom
zx000097:feature/add-agent-discovery

Conversation

@zx000097

@zx000097 zx000097 commented Sep 2, 2026

Copy link
Copy Markdown

Summary

  • add CLI setup and remove commands for agent discovery and configuration
  • support GitHub Copilot, Claude, and Codex with managed instruction updates
  • package the Microsoft Learn CLI skill assets and document the new workflows
  • add unit coverage and repository validation for the setup surface

Copilot AI lite review requested due to automatic review settings September 2, 2026 00:03

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The managed-markdown end-marker search logic can select the wrong marker and corrupt or mis-edit instruction files, and the CLI development docs include Windows-only commands.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR adds a “CLI-first” agent discovery workflow to the Microsoft Learn CLI so users can install/remove a bundled skill plus always-loaded instructions for GitHub Copilot, Claude Code, and Codex, without configuring MCP.

Changes:

  • Introduces mslearn setup / mslearn remove commands that write/remove managed discovery assets in user or project scope (including Codex managed-section edits to AGENTS.md / AGENTS.override.md).
  • Bundles discovery assets into the npm package (cli/assets/microsoft-learn-cli/*) and updates documentation to describe CLI-first vs plugin (MCP-first) modes.
  • Expands unit coverage around installation/removal idempotency and updates repo validation to include the new CLI files/assets.
File summaries
File Description
scripts/validate-repo.ps1 Adds new CLI command/setup modules and packaged assets to the repo validator allowlist.
README.md Documents the new CLI-first setup/remove workflow and clarifies CLI-first vs MCP-first modes.
cli/test/unit/cli.test.ts Adds filesystem-backed tests covering setup/remove behavior, idempotency, and Codex managed-section handling.
cli/src/setup/managed-markdown.ts Implements managed-section upsert/removal helpers for Codex instruction files.
cli/src/setup/copilot.ts Defines Copilot discovery file locations for global/project scope.
cli/src/setup/agents.ts Centralizes per-agent discovery paths/assets and instruction formatting (e.g., Copilot frontmatter).
cli/src/index.ts Registers new setup and remove commands in the CLI program.
cli/src/context.ts Extends CLI context to include cwd and homeDir for path resolution.
cli/src/commands/setup.ts Implements mslearn setup to install skills/instructions across selected agents/scopes.
cli/src/commands/remove.ts Implements mslearn remove to remove only managed discovery content and preserve unrelated files.
cli/README.md Adds “Agent discovery” docs and updates command reference and development instructions.
cli/package.json Ensures assets/ ships in the npm package and makes build remove dist/ before compiling.
cli/assets/microsoft-learn-cli/SKILL.md Adds the bundled CLI-first skill content installed into agent skill directories.
cli/assets/microsoft-learn-cli/INSTRUCTIONS.md Adds the bundled always-loaded instruction content referenced by setup.
Review details
  • Files reviewed: 14/14 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread cli/src/setup/managed-markdown.ts
Comment thread cli/README.md Outdated
@zx000097
zx000097 marked this pull request as draft September 2, 2026 00:08
@zx000097

zx000097 commented Sep 2, 2026

Copy link
Copy Markdown
Author

zx000097 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”), and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your contributions to Microsoft open source projects. This Agreement is effective as of the latest signature date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

zx000097 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

Zane Bong and others added 2 commits September 2, 2026 14:41
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@zx000097
zx000097 marked this pull request as ready for review September 2, 2026 07:12
@Eimasogi

Copy link
Copy Markdown
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants