Skip to content

Separate NeoGradle release clean and build phases #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SkyBlade1978 merged 2 commits into from
Sep 11, 2026
Merged

Separate NeoGradle release clean and build phases #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
557bb4c
Separate release clean and build phases
SkyBlade1978 Sep 11, 2026
95f2d50
Merge NeoGradle release build-order fix
SkyBlade1978 Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions .github/workflows/deploy-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,12 +362,16 @@ jobs:
- name: Build, test, and audit once
run: |
chmod +x ./gradlew
./gradlew clean check build javadoc verifyReleaseDependencies verifyReleaseArtifacts writeReleaseChecksums \
-PorespawnVerificationRepository="${{ steps.orespawn.outputs.repository }}" \
--no-daemon --stacktrace \
-Dorg.gradle.java.installations.paths="${{ steps.java-paths.outputs.paths }}" \
-Dorg.gradle.java.installations.auto-detect=false \
gradle_args=(
-PorespawnVerificationRepository="${{ steps.orespawn.outputs.repository }}"
--no-daemon --stacktrace
-Dorg.gradle.java.installations.paths="${{ steps.java-paths.outputs.paths }}"
-Dorg.gradle.java.installations.auto-detect=false
-Dorg.gradle.java.installations.auto-download=false
)
./gradlew clean "${gradle_args[@]}"
./gradlew check build javadoc verifyReleaseDependencies verifyReleaseArtifacts writeReleaseChecksums \
"${gradle_args[@]}"

- name: Stage the immutable release artifact
id: artifact
Expand Down
3 changes: 3 additions & 0 deletions src/test/java/zone/moddev/mc/mineralogy/WorkflowContractTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,9 @@ public void dispatcherProtectsPublishedVersionsAndUsesOneOrderedBundle() throws
assertTrue(deploy.contains("version-type: ${{ inputs.curseforge_release_level }}"));
assertTrue(deploy.contains("github-prerelease: false"));
assertTrue(deploy.contains("version-type: release"));
assertFalse(deploy.contains("./gradlew clean check build"));
assertTrue(deploy.contains("./gradlew clean \"${gradle_args[@]}\""));
assertTrue(deploy.contains("./gradlew check build javadoc verifyReleaseDependencies"));
assertEquals(2, countOccurrences(deploy, "bash gradle/stage-orespawn-release.sh"));
assertTrue(deploy.contains("-PorespawnVerificationRepository=\"${{ steps.orespawn.outputs.repository }}\""));

Expand Down
Loading