Skip to content

fix(e2b): accept nullable sandbox information domains - #600

Merged
SaladDay merged 1 commit into
aos/cutoverfrom
aos/fix-e2b-nullable-sandbox-information-domain
Oct 8, 2026
Merged

SaladDay merged 1 commit into
aos/cutoverfrom
aos/fix-e2b-nullable-sandbox-information-domain

Conversation

@SaladDay

@SaladDay SaladDay commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

E2B SDK information responses can omit the sandbox domain. The provider treated these valid responses as ownership failures, rejecting provisioning before bootstrap and preventing cleanup from reaching Kill. Accept the SDK’s nullable information field while retaining metadata, template and resource checks.

Create connection destinations remain strictly validated, and restoring saved connection material validates its destination before any envd request. Information responses never supply connection material.

Validation: 5 template tests, 222 helper tests, the generated helper contract, and Go E2B adapter tests pass. Regressions use the pinned SDK model conversion and cover lifecycle, nullable/omitted domains, foreign destinations, uncertain Create and saved-connection recovery. Negative controls reproduce both the original failure and the unsafe recovery behavior without the guard.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@SaladDay
SaladDay merged commit 4b5e6bf into aos/cutover Oct 8, 2026
16 of 17 checks passed
@SaladDay
SaladDay deleted the aos/fix-e2b-nullable-sandbox-information-domain branch October 8, 2026 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant